fix: Remove Google Fonts API dependency#157
Merged
hummusonrails merged 3 commits intomasterfrom Jan 18, 2024
Merged
Conversation
hummusonrails
changed the title
hummusonrails
changed the title
hummusonrails
changed the title
cold-briu
approved these changes
Jan 18, 2024
Contributor
cold-briu
left a comment
cold-briu
left a comment
There was a problem hiding this comment.
Not only is removing external deps but simplifying some code at the same time.
Great job, thank you so much.
matt-user
pushed a commit
that referenced
this pull request
Dec 10, 2024
* remove google fonts api dependency * reorder font loading priority * prettier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Google Fonts API is returning a 404 currently, which raises the issue that we should remove the external dependency and store the two fonts we require from it locally.