Skip to content

feat: add Arcana Wallet connector#476

Open
shrinathprabhu wants to merge 18 commits intoFuelLabs:mainfrom
shrinathprabhu:feat/add-arcana-wallet-connector
Open

feat: add Arcana Wallet connector#476
shrinathprabhu wants to merge 18 commits intoFuelLabs:mainfrom
shrinathprabhu:feat/add-arcana-wallet-connector

Conversation

@shrinathprabhu
Copy link

@shrinathprabhu shrinathprabhu commented Feb 11, 2025

Summary

Adds connector for Arcana Wallet (https://arcana.network)

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@vercel
Copy link

vercel bot commented Feb 11, 2025

@shrinathprabhu is attempting to deploy a commit to the Fuel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Feb 11, 2025

Thanks for the contribution! Before we can merge this, we need @shrinathprabhu to sign the Fuel Labs Contributor License Agreement.

@shrinathprabhu shrinathprabhu changed the title Add arcana wallet connector Add Arcana Wallet connector Feb 11, 2025
@vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:24pm

@helciofranco helciofranco changed the title Add Arcana Wallet connector feat: add Arcana Wallet connector Feb 12, 2025
@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Feb 24, 2025

Thanks for the contribution! Before we can merge this, we need @svarcoder to sign the Fuel Labs Contributor License Agreement.

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when importing a seed phrase in arcana wallet, its not getting the correct fuel address

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I try to connect to Fuel Wallet, if Arcana is also installed, it will answer to connections asked to Fuel Wallet.

Arcana should only interact when the call is for Arcana Connector, when it's a Fuel Wallet connection it should be totally out of the way

Screen.Recording.2025-04-24.at.22.29.10.mov

@shrinathprabhu
Copy link
Author

Hi @LuizAsFight could you recheck the PR again, I've resolved all the issues in the wallet

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix conflict in pnpm-lock ?

I recommend just doing

rm -rf **/**/node_modules **/**/.turbo **/**/.next **/**/dist; rm -rf pnpm-lock.yaml; git checkout main pnpm-lock.yaml; pnpm install;

this way you base on main pnpm-lock + just install / update new dependencies

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Jul 23, 2025

Thanks for the contribution! Before we can merge this, we need @shrinathprabhu @svarcoder to sign the Fuel Labs Contributor License Agreement.

@shrinathprabhu
Copy link
Author

Hi @LuizAsFight could you recheck the PR again, I've resolved all the conflicts

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after 2 refreshes the session is lost

Screen.Recording.2025-07-23.at.12.32.35.mov

to prevent this kind of issue I'd recommend including e2e tests (similar to what we already have for other connectors https://github.com/FuelLabs/fuel-connectors/blob/main/e2e-tests/runner/examples/connectors/FuelWalletConnector/FuelWalletConnector.test.ts)

we already have functions that centralize some needed tests, the main work on this is to have the arcana env setup, like installing the extension, connecting to account, approve txs in the extension etc..

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the transfer screen is showing incorrect "To"

Image

the right "To" was 0xA671949e92E3Cf75A497f6759C785336308f8867B677Defe1bA71d5979197BAF
https://app-testnet.fuel.network/tx/0x795705f565638f0f1c893c963b18968de88a8929068d04104231f7b7d6846221/simple

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Sign Message" is not working
image

Image

I see this error on console:

Image

@shrinathprabhu
Copy link
Author

the transfer screen is showing incorrect "To"

Image the right "To" was 0xA671949e92E3Cf75A497f6759C785336308f8867B677Defe1bA71d5979197BAF https://app-testnet.fuel.network/tx/0x795705f565638f0f1c893c963b18968de88a8929068d04104231f7b7d6846221/simple

@LuizAsFight fixed this in wallet

@shrinathprabhu
Copy link
Author

shrinathprabhu commented Jul 29, 2025

after 2 refreshes the session is lost

Screen.Recording.2025-07-23.at.12.32.35.mov
to prevent this kind of issue I'd recommend including e2e tests (similar to what we already have for other connectors https://github.com/FuelLabs/fuel-connectors/blob/main/e2e-tests/runner/examples/connectors/FuelWalletConnector/FuelWalletConnector.test.ts)

we already have functions that centralize some needed tests, the main work on this is to have the arcana env setup, like installing the extension, connecting to account, approve txs in the extension etc..

@LuizAsFight fixed this issue

@shrinathprabhu
Copy link
Author

"Sign Message" is not working image

Image I see this error on console: Image

fixed this in wallet @LuizAsFight , sharing the build on tg

@LuizAsFight
Copy link
Contributor

hey guys, was checking the PR + wallet zip extension here, and found a critical issue:

steps to repro:
1- import from seed phrase
2- select acc 1, 2 and 3
image

the fuel accounts shown are the same from fuel wallet when importing same seed phrase
image

3- then on next step, choose to setup only for layer 2. It tries setting up and then I get an error
image

4- after this error, the arcana wallet stays open, and if I check my accounts I see this
image

5- but after closing the arcana wallet and opening it again, I see the fuel account addresses are different from the one imported (EVM addresses stay the same though)
image

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment above + pnpm-lock conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants