fix: account lookup error in wallet management functions#1688
Open
famouswizard wants to merge 1 commit intoFuelLabs:masterfrom
Open
fix: account lookup error in wallet management functions#1688famouswizard wants to merge 1 commit intoFuelLabs:masterfrom
famouswizard wants to merge 1 commit intoFuelLabs:masterfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @famouswizard to sign the Fuel Labs Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update addresses an important issue in the wallet management functions related to the
getAccountByNamemethod. Prior to this change, if the account with the specified name was not found, the code would fail silently, leading to potential issues later in the flow.What was fixed:
getAccountByNamefunction now explicitly checks if the account exists. If not, it throws an error with a descriptive message indicating that the account could not be found.Why it matters:
Without this fix, it was possible for the tests or functionality relying on this method to proceed with an invalid state, causing hard-to-debug errors later in the process. By adding this validation, we ensure that the flow fails gracefully with a clear error message, making it much easier to diagnose issues and improving the robustness of the system.
Additional notes:
Thank you for reviewing this update!