Improves the UI atomization and the relative documentation #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmammino
reviewed
Feb 22, 2017
Member
lmammino
left a comment
lmammino
left a comment
There was a problem hiding this comment.
Just some minor comments around the presence of commented code here and there. If you think there is a good reason you are good to merge, otherwise I would advise to delete such comments and then merge.
| padding: 0 ($space-base * 2) $space-base; | ||
| } | ||
| } | ||
| // &__frame {} |
Member
There was a problem hiding this comment.
can this one be deleted at all?
| } | ||
| } | ||
|
|
||
| // &__headline { |
Member
There was a problem hiding this comment.
same here, do we want to maintain this stuff commented? I am always a bit against commented code, unless there is a very strong reason.
| &__footer { | ||
| padding: $space-small $h-unit $space-medium; | ||
| } | ||
| // &__footer {} |
| padding: ($v-unit * 2) 0; | ||
| padding: $space-small 0; | ||
|
|
||
| // &__list {} |
| &__list { | ||
| border: 1px solid neutral-color('lower'); | ||
| } | ||
| // &__list {} |
| } | ||
|
|
||
| &__item { | ||
| /* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.