ran babel-upgrade to keep up with beta #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Closes #126 |
glebec
reviewed
Aug 3, 2018
| "@babel/env" | ||
| /* | ||
| Babel uses these "presets" to know how to transpile your Javascript code. Here's what we're saying with these: | ||
Member
There was a problem hiding this comment.
is there a reason for losing this line break? It seems arbitrary.
Contributor
Author
There was a problem hiding this comment.
No, just a copy/paste issue when putting the .babelrc back together.
glebec
reviewed
Aug 3, 2018
Member
glebec
left a comment
glebec
left a comment
There was a problem hiding this comment.
This upgrades a lot of seemingly-unrelated packages. Are we concerned about that?
Contributor
Author
|
I am ambivalent re: the other package updates. In theory they are all minor upgrades, but that's no guarantee. Our micro test-suite passes... so do we feel good about that? ( This is a potential argument a blessed grace-shopper solution with tests that can stand as a QA tool for boilermaker upgrades. ) |
glebec
approved these changes
Aug 3, 2018
Member
|
I feel similarly. Just wanted to bring it up as a sanity check. |
EthanG19
pushed a commit
to D3Doritos/AllSign
that referenced
this pull request
Nov 26, 2019
* ran babel-upgrade to keep up with beta * restore whitespace in .babelrc comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a stackathon student run into deprecation warnings for the
stage-*babel presets.Looks like those preset bundles are on the way out in favor of explicit opt-in.
I ran the codemod from babel: https://github.com/babel/babel-upgrade
And this is the result.