API joint for pulsar backend: delete, start, stop function.#41
Merged
RobertIndie merged 41 commits intoFunctionStream:mainfrom Jun 24, 2021
Merged
API joint for pulsar backend: delete, start, stop function.#41RobertIndie merged 41 commits intoFunctionStream:mainfrom
RobertIndie merged 41 commits intoFunctionStream:mainfrom
Conversation
views\function\components\FunctionTable.vue mock\services\func.js
views\function\components\FunctionTable.vue mock\services\func.js
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
� Conflicts: � front-end/src/views/function/components/FunctionTable.vue
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
Co-authored-by: Zike Yang <zkyang@streamnative.io>
…, Get function stats, Get function status
…into better1719-table
RobertIndie
reviewed
Jun 20, 2021
Contributor
RobertIndie
left a comment
RobertIndie
left a comment
There was a problem hiding this comment.
There is a error when deleting a function:
Access to XMLHttpRequest at 'http://localhost:3000/admin/v3/functions/public/default/api-func/delete' from origin 'http://localhost:8000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: It does not have HTTP ok status.
It may be some problems with CORS in the pulsar proxy. I will take a look later.
RobertIndie
requested changes
Jun 21, 2021
| stats: ({ funcName }) => `/admin/v3/functions/public/default/${funcName}/stats`, | ||
| status: ({ funcName }) => `/admin/v3/functions/public/default/${funcName}/status`, | ||
| trigger: ({ funcName }) => `/admin/v3/functions/public/default/${funcName}/trigger`, | ||
| deleteFunc: ({ funcName }) => `/admin/v3/functions/public/default/${funcName}/delete`, |
Contributor
There was a problem hiding this comment.
This URL is incorrect. It does not need to contain delete in the delete URL. Please check with the postman.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #8