This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Feature/pacifista plus #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for Pacifista Plus functionality by adding new service and DTO classes for managing billing and payment workflows. Key changes include:
- Addition of new billing DTOs (PaypalPlanDTO and PaypalSubscriptionDTO) and exports in the public API.
- Implementation of a new PacifistaPlusPaymentService for handling subscription operations.
- Updates to existing DTOs to enforce required properties and add constructors.
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/funixproductions-requests/src/public-api.ts | Added exports for new billing and payment DTOs and services |
| projects/funixproductions-requests/src/lib/services/pacifista-api/web/shop/payment/services/PacifistaPlusPaymentService.ts | Introduced a new service for Pacifista Plus payment operations |
| projects/funixproductions-requests/src/lib/services/pacifista-api/web/shop/payment/dtos/requests/PacifistaPaymentRequestDTO.ts | Updated DTOs to make properties required and added constructors |
| projects/funixproductions-requests/src/lib/services/pacifista-api/web/shop/categories/dtos/PacifistaShopCategoryDTO.ts | Converted properties to required and added a constructor |
| projects/funixproductions-requests/src/lib/services/pacifista-api/web/shop/articles/dtos/PacifistaShopArticleDTO.ts | Updated properties to required with an additional markDownDescription field |
| projects/funixproductions-requests/src/lib/services/funixproductions-api/billing/dtos/PaypalSubscriptionDTO.ts | Added new DTO fields for Paypal subscriptions |
| projects/funixproductions-requests/src/lib/services/funixproductions-api/billing/dtos/PaypalPlanDTO.ts | Added new DTO implementation for Paypal plans |
Files not reviewed (2)
- package.json: Language not supported
- projects/funixproductions-requests/package.json: Language not supported
Comments suppressed due to low confidence (1)
projects/funixproductions-requests/src/lib/services/pacifista-api/web/shop/payment/dtos/requests/PacifistaPaymentRequestDTO.ts:1
- Consider renaming 'PacifistaShopArtcileRequestDTO' to 'PacifistaShopArticleRequestDTO' to correct the spelling mistake.
export class PacifistaPaymentRequestDTO {
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.