[REFACTOR] Fold PolymodExprEx into Expr#344
Merged
EliteMasterEric merged 1 commit intoFunkinCrew:experimentalfrom Feb 15, 2026
Merged
[REFACTOR] Fold PolymodExprEx into Expr#344EliteMasterEric merged 1 commit intoFunkinCrew:experimentalfrom
PolymodExprEx into Expr#344EliteMasterEric merged 1 commit intoFunkinCrew:experimentalfrom
Conversation
NotHyper-474
force-pushed
the
refactor/folded-errorEx
branch
from
662c363 to
90d8e82
Compare
NotHyper-474
changed the title
PolymodExprEx into Expr and PolymodPrinterEx into PrinterPolymodExprEx into Expr
NotHyper-474
force-pushed
the
refactor/folded-errorEx
branch
from
90d8e82 to
96a9125
Compare
EliteMasterEric
approved these changes
Feb 15, 2026
Member
EliteMasterEric
left a comment
EliteMasterEric
left a comment
There was a problem hiding this comment.
Great refactor, big improvement to the codebase, Funkin' builds and doesn't break scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
PolymodExprExandPolymodPrinterEx, then merges the former's code intoExprwhile also changing the code to account for the changes. This unifies the error handling forErrorExandError, resulting in way cleaner and less repetitive code.From my little bit of testing, the only functional change this has is that now some error messages don't display
hscriptClass(path/to/file.hxc):676: Error Messageanymore, which I suppose is fine sincePolymodScriptClass.reportError, albeit not including the file of origin, still includes the class name, function name, and line number.