Skip to content

Parse EJS when pushing a variation #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nselvidge merged 1 commit into from
Jun 22, 2015
Merged

Parse EJS when pushing a variation #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions lib/variation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
var util = require('util');
var path = require('path');
var _ = require("lodash");
var ejs = require("ejs");

var fileUtil = require("./file-util");
var logger = require("./logger");
var readConfig = require("./read-config");
var OptimizelyClient = require("optimizely-node-client");
var OptCLIBase = require("./optcli-base");
var Assets = require('./assets');

function Variation(attributes, baseDir) {
Variation.super_.call(this, attributes, baseDir);
Expand Down Expand Up @@ -38,10 +40,20 @@ Variation.prototype.getJS = function() {
}

Variation.prototype.createRemote = function(client, remote) {
//assume assets are in experiment.baseDir
var assets = new Assets({}, path.normalize(this.baseDir + "/.."));
if (assets.JSONFileExists()) {
logger.log("info", "assets file found, loading");
assets.loadFromFile();
}

//create new variation
var varArgs = _.clone(this.attributes);
varArgs['js_component'] = this.getJS();
varArgs['js_component'] = String(ejs.render(this.getJS(), {
locals: {
assets: assets.attributes
}
}));
varArgs['experiment_id'] = experiment.attributes.id;

var self = this;
Expand All @@ -58,9 +70,19 @@ Variation.prototype.createRemote = function(client, remote) {
}

Variation.prototype.updateRemote = function(client) {
//create new experiment
//assume assets are in experiment.baseDir
var assets = new Assets({}, path.normalize(this.baseDir + "/.."));
if (assets.JSONFileExists()) {
logger.log("info", "assets file found, loading");
assets.loadFromFile();
}

var varArgs = _.clone(this.attributes);
varArgs['js_component'] = this.getJS();
varArgs['js_component'] = String(ejs.render(this.getJS(), {
locals: {
assets: assets.attributes
}
}));

var self = this;
return client.updateVariation(varArgs).then(function(variationAttrs) {
Expand Down