[Bug]: Submissions fail with "Missing folder tag"

[plum-pan]

Version

3.12.1

What happened?

With the latest update, grabbing a submission fails with faapi.exceptions.ParsingError: Missing folder tag . I've not yet found a submission it did not fail on.

I'm not familiar with the modern theme so I'm not sure what changed.

How to reproduce the bug?

api.submission(entry_id)

Relevant log output

"/var/www/html/.venv/lib/python3.13/site-packages/faapi/base.py", line 196, in submission
  sub: Submission = Submission(self.get_parsed(join_url("view", int(submission_id))))
"/var/www/html/.venv/lib/python3.13/site-packages/faapi/submission.py", line 194, in __init__
  self.parse()
"/var/www/html/.venv/lib/python3.13/site-packages/faapi/submission.py", line 255, in parse
  parsed: dict = parse_submission_page(self.submission_page)
"/var/www/html/.venv/lib/python3.13/site-packages/faapi/parse.py", line 545, in parse_submission_page
  assert tag_folder is not None, _raise_exception(ParsingError("Missing folder tag"))
"/var/www/html/.venv/lib/python3.13/site-packages/faapi/exceptions.py", line 62, in _raise_exception
  raise err

[MatteoCampinoti94]

Yeah it's the new update, they changed tags again 😑

[MatteoCampinoti94]

Although I can't replicate it, all my tests are running fine. There are a few tags that changed in the descriptions but it's otherwise returning the correct data.

@plum-pan can you share one of the IDs that is giving you problems?

[MatteoCampinoti94]

All tests pass on all submissions I try. Are you sure you set the template to "Modern" and the theme to "Dark" @plum-pan?

[plum-pan]

Went through and pulled some for testing, all failed. 60214234, 63752846, 64553422. Confirmed Template Modern, Theme Dark. Double checked that version is 3.12.1.

[MatteoCampinoti94]

Zero issues on my end. Try deleting it and reinstalling it with no cache, because the only thing I can think of is that it's loading something incorrectly, or that your settings are somehow incompatible with it, but as far as I know the template and theme are the only things affecting the served HTML.

[plum-pan]

Did python3 -m pip install --upgrade --force-reinstall faapi inside my venv, set the cookies up by hand just to debug instead of using my existing code, still no change. Confirmed cookies are the same... cookies are not the same? Update cookies, run code again... same error. Verify cookies in stack, cookies same.

Not sure what to check at this point. Looks like line 527 in parse.py should be setting the variable?

tag_folder: Optional[Tag] = sub_page.select_one("a.button[href^='/scraps/'],a.button[href^='/gallery/']")

[MatteoCampinoti94]

Yep, it's that line, but it works fine both on my machine and on furaffinity-api.herokuapp.com.

I am extremely confused XD

Try getting the submission HTML via the FAAPI.get method:

response = api.get("/view/60214234")
response.raise_for_status()
with open("60214234.html", "w") as f:
    f.write(response.text)

Then I can see if it differs from what it's supposed to be.

PS: remember to remove your username/name from the HTML before sharing it here

[MatteoCampinoti94]

Oh and try checking it using uvx, it can create a venv on the fly with no caching:

uvx --no-cache --with faapi python

[plum-pan]

Did uvx exactly like you did there, same result (still not parsing). Only two things that should be different are that I'm on python 3.13.5 (highly unlikely it's related) or something is different on my account.

Here's a dump with api.get. I changed the username but I have an account that I use exclusively for API stuff since I don't normally use the modern theme. So I'm not super worried about it.

602.html

[MatteoCampinoti94]

Found it! It's the minigallery setting: it renders a completely different submission navigation with different tags.

Specifically, it uses an anchor tag that does not have the button class.

The good thing is that the container tag has the same favorite-nav class, so I only have to change the selector to .favorite-nav a[href^='/scraps/'], .favorite-nav a[href^='/gallery/'] and it will work with the minigallery setting :)

[plum-pan]

Huzzah! Thank you!

Confirmed that changing the setting fixed things for me as well. I think that minigallery is the default now as, again, I never touch anything on that FA account and just use it for API access.

Another FA update mitigated! I hope we get an actual API from them some day, I'm extremely glad FAAPI exists but it's a lot more work for everyone involved this way.

[MatteoCampinoti94]

Nevermind, they don't have the same container x3

But I found the right selectors that will work with both settings.

And yeah, I hope so too. I loved developing this library but playing whack-a-mole with FA's updates is annoying x3