Skip to content

add interpolation of HTC and T bulk#2

Merged
dodu94 merged 2 commits into
mainfrom
add-htc
Jun 2, 2026
Merged

add interpolation of HTC and T bulk#2
dodu94 merged 2 commits into
mainfrom
add-htc

Conversation

@dodu94
Copy link
Copy Markdown
Member

@dodu94 dodu94 commented Jun 2, 2026

Description

Add possibility to interpolate HTC and T Bulk

Summary by CodeRabbit

  • New Features

    • Heat Transfer Coefficient (HTC) interpolation now supported in the system
  • Documentation

    • Added HTC mesh definitions and source data files for configuration reference
  • Tests

    • Enhanced test coverage for HTC interpolation workflows and ANSYS export validation

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Warning

Review limit reached

@dodu94, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 34 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0d7f0fd-f9bc-473f-8023-540801da250d

📥 Commits

Reviewing files that changed from the base of the PR and between edf41ab and f5343ab.

📒 Files selected for processing (1)
  • README.md

Walkthrough

This PR introduces Heat Transfer Coefficient (HTC) as a new interpolated load type. The implementation adds HTC to the configuration enum, extends template selection to return CONV and TEMP modes for HTC, and provides comprehensive test coverage with sample destination mesh and HTC source data files.

Changes

HTC Interpolation Feature

Layer / File(s) Summary
HTC Load Type Definition
src/interpcore/config.py
Adds INTERPOLATED_LOAD_TYPE.HTC enum member and extends __post_init__ to set num_components = 2 for HTC configurations.
Template Selection for HTC
src/interpcore/interpolator.py
Extends _select_template() to return two ANSYS templates (CONV and TEMP modes) when HTC load type is selected.
HTC Test Coverage and Sample Data
doc/htc/destination_mesh.txt, doc/htc/source_data/htc_data.txt, tests/test_interpolator.py
Provides sample node mesh coordinates and HTC/Tref source data, plus test fixtures and three new test methods validating HTC interpolation, ANSYS export output, and template selection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A heat coefficient hops into place,
With templates and configs in perfect grace,
Two components dancing, CONV and TEMP align,
Tests validate each node coordinate line,
Another load type conquered—the interpolator's divine! 🌡️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add interpolation of HTC and T bulk' clearly summarizes the main change: adding HTC interpolation support. While 'T bulk' is mentioned in the title but 'Tref' (reference temperature) appears in the data files, this is a minor discrepancy. The title accurately captures the primary objective of the PR.
Docstring Coverage ✅ Passed Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-htc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dodu94 dodu94 merged commit 12775c0 into main Jun 2, 2026
9 checks passed
@dodu94 dodu94 deleted the add-htc branch June 2, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant