Add support for Content-Encoding on the HTTP request #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidmain
reviewed
Nov 5, 2025
Member
voidmain
left a comment
voidmain
left a comment
There was a problem hiding this comment.
Nothing major, but it looks like there is a dead variable.
| case Headers.ContentEncodingLower: | ||
| String[] encodings = value.split(","); | ||
| List<String> contentEncodings = new ArrayList<>(1); | ||
| int encodingIndex = 0; |
Member
There was a problem hiding this comment.
I don't think this variable is needed. Can we remove it?
Member
Author
There was a problem hiding this comment.
Hmm.. not sure what that was for.. but not necessary any longer. 😎
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the
Content-Encodingon the HTTP request to match our response compression support. This includesgzipanddeflate.We could consider adding support for additional compression algorithms such as Brotli (
br) or zStandard (zstd) - but to do that we'd likely have to pull in 3rd party libs, or implement them ourselves. This would go against our no-deps policy. So if we did, perhaps we'd want to just allow them to be added via separate jars so we don't pollute the core project.It is interesting to note that not a lot of HTTP servers support request compression. Sort of makes sense since if you assume the client is generally not sending large requests, only receiving large request. I don't see any harm in supporting it though - even if it isn't super common to use it.