Not declaring OpenAlex missing a DOI if 429'd #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
maykcaldas,
mskarlin,
nadolskit,
sidnarayanan and
whitead
dosubot
bot
added
the
size:M
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the OpenAlex integration by improving error handling, test coverage, and timeout configuration. The changes address specific timeout issues observed with certain DOIs and add support for distinguishing between DOIs that exist but aren't open access versus DOIs that don't exist in OpenAlex.
- Updated error handling to specifically catch 404 responses and provide more detailed error messages
- Extended test coverage to include more OpenAlex scenarios (open access, non-open access, and not found cases)
- Added timeout configuration to the test client to handle slow API responses
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/paperqa/clients/openalex.py | Enhanced error handling to distinguish 404s from other HTTP errors, removed unused import, added comment explaining timeout issues |
| tests/test_clients.py | Expanded test parameters to cover more scenarios (in OpenAlex with/without OA, not in OpenAlex) and added timeout configuration |
| tests/cassettes/*.yaml | Added VCR cassettes for new test cases capturing API responses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sidnarayanan
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also:
ConnectTimeout