fix: use -O flag for script output file (util-linux 2.42 compat)#421
Merged
korewaChino merged 1 commit intoFyraLabs:mainfrom Apr 5, 2026
Merged
Conversation
util-linux 2.42 added '+' to getopt, stopping option parsing at the first non-option argument. This breaks the old invocation where /dev/null was passed as a positional arg after the -f flag. Using -O /dev/null explicitly works on both old and new versions. Ref: terrapkg/packages#11057
korewaChino
approved these changes
Apr 5, 2026
Contributor
Author
|
To validate: util-linux 2.41 (Fedora 44)podman run --rm quay.io/fedora/fedora:44 bash -c ' util-linux 2.42 (Rawhide)podman run --rm quay.io/fedora/fedora:rawhide bash -c ' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util-linux 2.42 added
+to the getopt string inscript(1), which stops option parsing at the first non-option argument. This causes the current invocation:to fail with
unexpected number of arguments, because/dev/null(positional) stops option parsing, leaving-qand-cas unrecognized extra arguments.The fix uses
-O /dev/null(explicit--log-out) instead of a positional argument. This works on both old and new versions ofscript(-Ohas been available since util-linux 2.35).Ref: terrapkg/packages#11057