Skip to content

Add UI_FONT_SIZE const in editor#914

Merged
mrDIMAS merged 6 commits intoFyroxEngine:masterfrom
CopeFiend:use_unique_key_for_editor_fonts
Apr 30, 2026
Merged

Add UI_FONT_SIZE const in editor#914
mrDIMAS merged 6 commits intoFyroxEngine:masterfrom
CopeFiend:use_unique_key_for_editor_fonts

Conversation

@CopeFiend
Copy link
Copy Markdown
Contributor

@CopeFiend CopeFiend commented Apr 25, 2026

Description

Adds a unique Style key in Editor to be used over the default used in fyrox-ui. (Not yet implemented)

Related Issue(s)

Related issue: #910 , prerequisite for future changes.

Review Guidance

  • No visible change in editor, this is a back-end only change that lays the foundation for the future.
  • In editor/lib.rs, added new constant
pub const UI_FONT_SIZE: &'static str = "Editor.UI.Font.Size";

to be used over pub const FONT_SIZE as declared in fyrox-ui/src/style/mod.rs

Screenshots/GIFs

N/A

Checklist

  • My code follows the project's code style guidelines
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes don't generate new warnings or errors
  • No unsafe code introduced (or if introduced, thoroughly justified and documented)

@CopeFiend CopeFiend closed this Apr 25, 2026
@CopeFiend CopeFiend reopened this Apr 25, 2026
@CopeFiend
Copy link
Copy Markdown
Contributor Author

Split from #911

@CopeFiend CopeFiend marked this pull request as draft April 26, 2026 16:42
@CopeFiend CopeFiend marked this pull request as ready for review April 26, 2026 16:54
@CopeFiend CopeFiend force-pushed the use_unique_key_for_editor_fonts branch from d31832d to 3ebf20f Compare April 28, 2026 14:05
@CopeFiend CopeFiend force-pushed the use_unique_key_for_editor_fonts branch from 3ebf20f to 1176ac0 Compare April 28, 2026 14:12
@CopeFiend
Copy link
Copy Markdown
Contributor Author

@mrDIMAS Would like to get some early feedback on the rest of the draft, #911 .

The plan is to split the branch into multiple smaller PRs and merge one by one, just need to make sure the foundations are good.

@mrDIMAS mrDIMAS merged commit 8e9d257 into FyroxEngine:master Apr 30, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants