Skip to content

Conversation

@rickskyy
Copy link
Collaborator

Documentation of RDF tools.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.049% when pulling aaa385d on rickskyy:jupyter-doc into ae93c27 on G-Node:dev-odml-rdf.

@rickskyy rickskyy mentioned this pull request Oct 6, 2017
"cell_type": "markdown",
"metadata": {},
"source": [
"##RDFWriter class"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace after ## missing. ;)

"cell_type": "markdown",
"metadata": {},
"source": [
"##RDFReader class"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ## comment above.

"f = tempfile.NamedTemporaryFile(mode='w', suffix=\".ttl\")\n",
"path = f.name\n",
"\n",
"# possible to use 'ttl' instead of 'turtle'\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using format ttl here (and in all occurrences below) leads to the error PluginException: No plugin registered for (ttl, <class 'rdflib.serializer.Serializer'>) when I'm running the notebook. I'm using python3.5 with rdflib v4.2.1. Maybe we just use format turtle everywhere to avoid any version conflicts in general.

@@ -0,0 +1,380 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the whitespace from the filename RDF tools.ipynb.

"cell_type": "markdown",
"metadata": {},
"source": [
"**RDF (Resource Description Framework)** is one of the three foundational [Semantic Web](https://en.wikipedia.org/wiki/Semantic_Web) technologies, the other two being SPARQL and OWL.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the proper citation or rewrite this paragraph.

"cell_type": "markdown",
"metadata": {},
"source": [
"![Image](http://dublincore.org/documents/2008/01/14/dc-rdf/rdfexamplefig.png)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I saw on the dublincore page, their content is licensed under the "Creative Commons Attribution 3.0 Unported License" (bottom of the dublincode page). We are allowed to use the graph, as long as we properly cite it, please check the details via the link they provide. ;)

"cell_type": "markdown",
"metadata": {},
"source": [
"Let's create the example odML document."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also provide a link to the odML tutorial at this point? (https://g-node.github.io/python-odml/tutorial.html)

@mpsonntag
Copy link
Contributor

Changes requested here are handled via PR #173.

@mpsonntag mpsonntag closed this Oct 10, 2017
@rickskyy rickskyy deleted the jupyter-doc branch October 17, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants