Property tests and tweaks#269
Merged
jgrewe merged 11 commits intoG-Node:masterfrom Mar 27, 2018
Merged
Conversation
Replaces 'odml.Property.append' with '.extend'. Includes some PEP8 fixes.
Replaces 'odml.Property.append' with '.extend'. Includes some PEP8 fixes.
Removes obsolete name and value_origin tests.
Adds extend test, moves extend related code from test_value to test_value_extend and adds additional extend test code.
Adds append test, moves append related code from test_value to test_value_append and adds additional append test code.
achilleas-k
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more Property tests and adds the following tweaks:
Property.appendexits on empty values but accepts0andFalse.uncertaintytoNoneif an empty string is passed to it.valuetest and addsextend,appendandsimple_attributestests.