Skip to content

Document updates and tests#277

Merged
jgrewe merged 24 commits intoG-Node:masterfrom
mpsonntag:refDoc
Apr 13, 2018
Merged

Document updates and tests#277
jgrewe merged 24 commits intoG-Node:masterfrom
mpsonntag:refDoc

Conversation

@mpsonntag
Copy link
Copy Markdown
Contributor

@mpsonntag mpsonntag commented Apr 13, 2018

This PR mainly updates and refactors Document and base.sectionable methods:

  • fixes a bug in the setting and getting of the date of a Document.
  • sets all simple attributes to None if it is set to empty string to be consistent with the same behavior in Section and Property.
  • refactors the base.sectionable.insert method.
  • refactors the base.sectionable.append method.
  • adds the base.sectionable.extend method.
  • now consistently uses BaseSection or BaseDocument for isinstance checks throughout base instead of a mixture of BaseSection and Section.
  • Updates the README introduction.
  • adds document tests.
  • adds document integration tests.
  • removes outdated document tests.

mpsonntag added 23 commits April 11, 2018 10:12
@mpsonntag
[document] Fix date get
6540665 
Document date get always returned
the current date, if the actual value
was not set.
@mpsonntag
[document] Fix date set
60dadf3 
The dtypes.set method does not
check proper date format, using
dtypes.date_set instead.
@mpsonntag
[test/doc] Add date test
9bea28a
@mpsonntag
[document] Set simple attributes None on ''
1d694c0
@mpsonntag
[test/doc] Add simple attribute tests
c5f154e
@mpsonntag
[test/doc] Add terminology_equivalient test
43dd4dd
@mpsonntag
[sec/prop] odmlui _parent quickfix
d3f1b2a 
odmlui requires 'self._parent' to be set
at the beginning of the init.
@mpsonntag
[base/sectionable] Refactor insert
6ab40b9
@mpsonntag
[test/doc] Add insert test
0d2f7e5
@mpsonntag
[test] Remove outdated document test files
22db390
@mpsonntag
[base/sectionable] Add extend method
873f40c
@mpsonntag
[test/doc] Add extend test
7e9ab65
@mpsonntag
[base/sectionable] Refactor append method
9699331 
Due to the added extend method, support for appending
tuples is no longer required and removed to keep
append functionality consistent with Property
and Section append.
@mpsonntag
[test/doc] Add append test
2aa1905
@mpsonntag
[base/sectionable] Consistently use 'Base' classes
ae936bd
@mpsonntag
[base] Code cleanup
2e364c7
@mpsonntag
[README] Update introduction
0da16a8
@mpsonntag
[test/document int] Add file
23b79aa
@mpsonntag
[test/document int] Add save_load method
4bd5efb
@mpsonntag
[test/document int] Add id test
8a54b78
@mpsonntag
[test/document int] Add simple attributes test
9f83048
@mpsonntag
[test/document int] Add section test
7a63199
@mpsonntag
[document] Code cleanup
591deaa
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 13, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 74.468% when pulling b4fedcd on mpsonntag:refDoc into 40d088a on G-Node:master.

achilleas-k
achilleas-k approved these changes Apr 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgrewe jgrewe merged commit 23f9181 into G-Node:master Apr 13, 2018
@mpsonntag mpsonntag deleted the refDoc branch April 13, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrewe jgrewe jgrewe approved these changes

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mpsonntag @coveralls @jgrewe @achilleas-k