Flatten odml class hierarchy#278
Merged
jgrewe merged 11 commits intoG-Node:masterfrom Apr 18, 2018
Merged
Conversation
The functionality of 'is_valid_attribute' has already previously been migrated to dict_parser.
achilleas-k
approved these changes
Apr 18, 2018
Member
achilleas-k
left a comment
There was a problem hiding this comment.
Well, this is absolutely lovely. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR flattens the odml class hierarchy since it is unlikely that we will support differing odML class implementations any time soon.
base._baseobjclass, makingBaseObjectthe root odML class.doc.Documentclass, makingBaseDocumentthe only odML document class.section.Sectionclass, makingBaseSectionthe only odML section class.property.Propertyclass makingBasePropertythe only odML property class.The PR also
baseobjectandsectionabletoBaseObjectandSectionablerespectively.odmlparser.is_valid_attributemethod which had already previously copied to the new dictparser class.