Skip to content

Flatten odml class hierarchy#278

Merged
jgrewe merged 11 commits intoG-Node:masterfrom
mpsonntag:slimFast
Apr 18, 2018
Merged

Flatten odml class hierarchy#278
jgrewe merged 11 commits intoG-Node:masterfrom
mpsonntag:slimFast

Conversation

@mpsonntag
Copy link
Copy Markdown
Contributor

This PR flattens the odml class hierarchy since it is unlikely that we will support differing odML class implementations any time soon.

  • removing base._baseobj class, making BaseObject the root odML class.
  • removing doc.Document class, making BaseDocument the only odML document class.
  • removing section.Section class, making BaseSection the only odML section class.
  • removing property.Property class making BaseProperty the only odML property class.

The PR also

  • reorders various magic methods to the top of their respective class to easier spot where custom magic methods are defined.
  • renames baseobject and sectionable to BaseObject and Sectionable respectively.
  • removes outdated odmlparser.is_valid_attribute method which had already previously copied to the new dictparser class.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 74.627% when pulling f6dd160 on mpsonntag:slimFast into 23f9181 on G-Node:master.

Copy link
Copy Markdown
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is absolutely lovely. Approved.

@jgrewe jgrewe merged commit 617580c into G-Node:master Apr 18, 2018
@mpsonntag mpsonntag deleted the slimFast branch April 18, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants