feat: parse all lockfiles and load all databases before checking for vulnerabilities#101
Merged
feat: parse all lockfiles and load all databases before checking for vulnerabilities#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sort of did this when toying with a possible improvement with #94, and it is technically an improvement because it means we're only loading each database once instead of per lockfile
The real improvement (and reason for landing this) imo is that now the database loading details are outputted first:
I personally think that's a bit nicer because it's less noise when copying the output for a specific manifest.
Technically we could now optimise the loading of the databases to be done in parallel but they load pretty quickly already so I've not done that yet (though I'll probably do it at some point)