Turn order deprecation#235
Merged
hopshackle merged 88 commits intomasterfrom Jan 24, 2023
Merged
Conversation
…s is already done in ForwardModel - and having a single point for change is much less confusing
The Main phase is not used by all games, so it seemed sensible to refactor this to use setGamePhase(), and be clearer at point of use what it is doing
This now provides two hooks for sub-classes: _endRound() for stuff that is genuinely at the end of a round; before we increment timers, publish the ROUND_OVER event and move the player on _startRound() for set up at the start of the next round (which may not take place if the game ends)
…shed (otherwise incorrect timings are reported)
…h/TabletopGames into TurnOrderDeprecation
…h/TabletopGames into TurnOrderDeprecation
… variable name and getter)
…h/TabletopGames into TurnOrderDeprecation
…h/TabletopGames into TurnOrderDeprecation
# Conflicts: # pom.xml # src/main/java/core/Game.java # src/main/java/games/diamant/DiamantGame.java # src/test/java/test/games/dicemonastery/ActionTests.java # src/test/java/test/games/dicemonastery/CopyTests.java # src/test/java/test/games/dicemonastery/CoreGameLoopTests.java # src/test/java/test/games/dicemonastery/vOneEightTests.java
rdgain
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation of TurnOrder in the 6th Tagathon
TurnOrder is now deprecated. New games should be created by extending StandardForwardModel and AbstractGameState.
TurnOrder data is now in AbstractGameState
TurnOrder logic is now in StandardForwardModel