Skip to content

Fix/UI feature fixes#168

Merged
Indecisive613 merged 6 commits intomainfrom
fix/ui-feature-fixes
Mar 25, 2026
Merged

Fix/UI feature fixes#168
Indecisive613 merged 6 commits intomainfrom
fix/ui-feature-fixes

Conversation

@GAchuzia
Copy link
Copy Markdown
Owner

@GAchuzia GAchuzia commented Mar 25, 2026

Description

image

Fixes to UI based on recommendations from @Indecisive613
Sorry I didn't go into more details on all the fixes, but they should all be there!
I also updated the theme to use red instead of black for buttons

Fixes #167

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix/feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Manual tests
  • Linted/formatted

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- Add no-match warning for browse-similar Carleton dining results
- Update Recommendations wording
@GAchuzia GAchuzia requested a review from Indecisive613 March 25, 2026 17:52
Copy link
Copy Markdown
Collaborator

@Indecisive613 Indecisive613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Your changes address all the minor UI bugs that were identified.

My only nitpick is now with the capitalization on the various pages (because you have a commit that addresses capitalization).

On Home: Scan food -> Scan Food
On Browse: Browse food -> Browse Food (when no user is logged in this is okay, it's the logged in version that is bad)
Log out button: Log out -> Log Out
Log in button: Log in -> Log In
On Statistics: View other statistics -> View Other Statistics
On Recommendations: Choose another type -> Choose Another Type
On Scan Food: Remove photo -> Remove Photo
On Scan Food: Browse similar -> Browse similar
On Scan Food: Scan another -> Scan Another

Basically check that all buttons with multiple words have all words properly capitalized.

@GAchuzia GAchuzia requested a review from Indecisive613 March 25, 2026 18:23
Copy link
Copy Markdown
Collaborator

@Indecisive613 Indecisive613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Indecisive613 Indecisive613 merged commit 72011d4 into main Mar 25, 2026
@Indecisive613 Indecisive613 deleted the fix/ui-feature-fixes branch March 25, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Message for Empty Browse Similar

2 participants