This repository was archived by the owner on Jul 16, 2022. It is now read-only.
Fixed Invite.inviter (extensions) as was empty#79
Merged
HilbertGilbertson merged 2 commits intoGAwesomeBot:developmentfrom Feb 14, 2017
Merged
Fixed Invite.inviter (extensions) as was empty#79HilbertGilbertson merged 2 commits intoGAwesomeBot:developmentfrom
HilbertGilbertson merged 2 commits intoGAwesomeBot:developmentfrom
Conversation
As has been the problem with numerous other properties, Inviter was a getter.
This meant the invite creator's user object wasn't passing with the Invite
object and wasn't retrievable (an extension could not even see which user
created the invite).
To reproduce: `guild.getInvites(cb => {logMsg(JSON.stringify(cb.inviter))});`
Resolved by always passing the User object via .inviter.
HilbertGilbertson
added
reason: Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As has been the problem with numerous other properties, Inviter was a getter. This meant the invite creator's user object wasn't passing with the Invite object and wasn't retrievable (an extension could not even see which user created the invite).
To reproduce:
guild.getInvites(cb => {logMsg(JSON.stringify(cb))});Resolved by always passing the User object via .inviter.