fix(desktop): global I18nService init and locale sync on language change#371
Merged
bobleer merged 1 commit intoGCWing:mainfrom Apr 9, 2026
Merged
Conversation
- Initialize global I18nService at startup from config service so bot/remote-connect uses correct locale. - After i18n_set_language, update in-memory I18nService so responses match UI without restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I18nServiceduring desktop startup (from config service) so bot/remote-connect responses use the correct locale.i18n_set_language, sync the in-memoryI18nServiceso backend strings match the UI without restarting the app.Test plan
cargo check -p bitfun-desktop