refactor(core): extract shared types for function agents#482
Merged
GCWing merged 1 commit intoGCWing:mainfrom Apr 21, 2026
Merged
refactor(core): extract shared types for function agents#482GCWing merged 1 commit intoGCWing:mainfrom
GCWing merged 1 commit intoGCWing:mainfrom
Conversation
Extract duplicated types from git-func-agent and startchat-func-agent into a shared common module: - Language enum (Chinese, English) - AgentError struct with Display and Error traits - AgentErrorType enum (GitError, AnalysisError, InvalidInput, InternalError) - AgentResult<T> type alias Changes: - Add function_agents/common.rs with shared type definitions - Re-export shared types from both agent type modules for backward compatibility - Update imports in ai_service.rs, commit_generator.rs, context_analyzer.rs, work_state_analyzer.rs - Update function_agents/mod.rs to include common module and re-export shared types This is a pure refactoring with no functional changes. All existing APIs remain unchanged through re-exports. Generated with BitFun Co-Authored-By: BitFun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract duplicated types from git-func-agent and startchat-func-agent into a shared common module:
Changes:
This is a pure refactoring with no functional changes. All existing APIs remain unchanged through re-exports.
Generated with BitFun
Co-Authored-By: BitFun