feat(flow-chat): increase expanded preview max height for file operat…#530
Merged
limityan merged 2 commits intoGCWing:mainfrom Apr 25, 2026
Merged
feat(flow-chat): increase expanded preview max height for file operat…#530limityan merged 2 commits intoGCWing:mainfrom
limityan merged 2 commits intoGCWing:mainfrom
Conversation
…ion and terminal tool cards Split single preview max-height constants into streaming vs expanded variants: FileOperationToolCard: - FILE_OPERATION_STREAMING_MAX_HEIGHT (88px) for compact streaming preview - FILE_OPERATION_DIFF_MAX_HEIGHT (330px) for comfortable diff reading when manually expanded after completion TerminalToolCard: - TERMINAL_OUTPUT_STREAMING_MAX_HEIGHT (88px) for compact live output during execution - TERMINAL_OUTPUT_EXPANDED_MAX_HEIGHT (286px) for comfortable output reading when manually expanded after completion/cancellation Also fix TerminalToolCard extra prop to conditionally render only when there is actual content, preventing empty DOM elements from breaking card layout (border/width). Both use max-height (not fixed height) so content shorter than the limit shrinks naturally without blank space.
… guidance - Add WHEN TO USE / WHEN NOT TO USE sections to tool description - Add recommendation guidelines (first option + \
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split single preview max-height constants into streaming vs expanded variants:
FileOperationToolCard:
TerminalToolCard:
Also fix TerminalToolCard extra prop to conditionally render only when there is actual content, preventing empty DOM elements from breaking card layout (border/width).
Both use max-height (not fixed height) so content shorter than the limit shrinks naturally without blank space.