Session attention indicator, scroll fix, i18n terminology unification, and large-screen layout adjustments#532
Merged
limityan merged 4 commits intoGCWing:mainfrom Apr 26, 2026
Merged
Conversation
Increase chat content max-width from 900px to 1200px with a new 1400px breakpoint (1000px) for better utilization on high-resolution displays. Also widen input (700px -> 900px) and empty state (650px -> 800px) to stay proportional. Generated with BitFun Co-Authored-By: BitFun
Unify Chinese terminology by replacing all occurrences of 审查 with 审核 in both Simplified and Traditional Chinese locale files, plus related model copy strings, README, and component registry examples.
…and ask-user questions
Add high-priority attention indicator for sessions waiting for user input while not active. This complements the existing hasUnreadCompletion for finished sessions.
Changes:
* Add needsUserAttention field ('ask_user' | 'tool_confirm') to Session
* Show pulsing dot + attention badge in sidebar for non-active sessions
* Persist needsUserAttention in backend SessionMetadata
* Clear attention state when user switches to session or tool resolves
* Add i18n labels for all three locales
The three session notification states are now treated as peers:
* hasUnreadCompletion (completed/error): weak hint, small dot
* needsUserAttention (ask_user/tool_confirm): strong hint, pulsing dot + badge
* none: no indicator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a high-priority attention indicator for sessions awaiting user action, fixes a scroll issue for unread sessions, unifies Chinese terminology across locales, and relaxes chat area dimensions for larger screens.
Changes
feat: Add
needsUserAttentionfor pending tool confirmations and ask-user questionshasUnreadCompletionmechanism, establishing three peer notification states:hasUnreadCompletion(completed/error): weak hint, small dotneedsUserAttention(ask_user/tool_confirm): strong hint, pulsing dot + badgeneedsUserAttentionto the frontendSessiontype and backendSessionMetadatafix: Use
scrollToIndexfor unread session scroll-to-bottomVirtualMessageListwithscrollToIndexto avoid positioning errors when navigating to unread sessionsstyle(i18n): Unify Chinese terminology — replace «审查» with «审核»
model_copy.rs,README.zh-CN.md, and component registry examples to matchstyle: Relax chat area max-width for larger screens
max-width: 900px → 1200px (1000px at the 1400px breakpoint)ReviewTeamPagestyles refactored accordingly