Skip to content

Deep Review UX Improvements & Session Stability Fixes#547

Merged
limityan merged 5 commits intoGCWing:mainfrom
limityan:yanzhn/session
Apr 26, 2026
Merged

Deep Review UX Improvements & Session Stability Fixes#547
limityan merged 5 commits intoGCWing:mainfrom
limityan:yanzhn/session

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

@limityan limityan commented Apr 26, 2026

Deep Review UX Improvements & Session Stability Fixes

Summary

Improves Deep Review UX and prompt efficiency, fixes session list stability bugs (unread indicators, ordering).

Changes

  1. perf(deep-review): add efficiency rules and role-specific strategy directives to reviewer prompts (e0b7d79)

    • Enhanced reviewer prompts with per-role strategy directives to reduce redundant output
  2. fix: internationalize reviewer role description in deep review subagent pages (b4d389c)

    • Moved hardcoded reviewer role descriptions into i18n locale files
  3. fix: prevent unread session dots from reappearing after restart (f68866a)

    • buildSessionMetadata used ?? fallback that restored stale persisted values after clear; now uses in-memory value as source of truth
    • Backend no longer infers unread_completion from persisted runtime state during restore
  4. fix(web-ui): improve deep review action bar UX (d155dbd)

    • Added confirmation before replacing chat input; fixed overlay/scroll issues; removed minimize button; added i18n
  5. fix(web-ui): keep session ordering stable (b01b71d)

    • Removed lastActiveAt from sort key; uses lastFinishedAt/createdAt to prevent sessions from jumping on click

@limityan limityan force-pushed the yanzhn/session branch 3 times, most recently from cb297c1 to f7536d7 Compare April 26, 2026 13:34
Add confirmation before replacing chat input, fix overlay/scroll issues, remove minimize button and hint text, add i18n
The buildSessionMetadata function used ?? to fall back to existingMetadata for unreadCompletion and needsUserAttention. When the store cleared these fields (setting them to undefined), undefined ?? existingMetadata.unreadCompletion would restore the old persisted value, preventing the clear from reaching disk. On next app launch, initializeFromDisk would restore the stale value, causing green dots to reappear on old sessions.

Now the in-memory session value is used directly as the source of truth, so clears propagate correctly through JSON.stringify (which omits undefined properties) to the backend.

Generated with BitFun

Co-Authored-By: BitFun
@limityan limityan changed the title fix(web-ui): keep session ordering stable Deep Review UX Improvements & Session Stability Fixes Apr 26, 2026
@limityan limityan merged commit 0074bc6 into GCWing:main Apr 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant