fix(deep-review): subagent ignore-timeout, session recovery, UI polish & frontend reviewer generalization#556
Merged
limityan merged 4 commits intoGCWing:mainfrom Apr 27, 2026
Conversation
Replace React-specific references in the Frontend Reviewer agent description and deep-review prompts with generic frontend framework terminology (e.g., memoization, virtualization, effect/reactivity dependencies) so the reviewer is not limited to React codebases. - review_specialist_agents.rs: update FrontendReviewerAgent description - deep_review_agent.md: update ReviewFrontend normal/deep strategy prompts Generated with BitFun Co-Authored-By: BitFun
- Increase collapsed capsule height from 42px to 48px - Increase capsule max-width from fixed 300px to min(380px, 80%) so it breathes better on wide panels while adapting to narrow ones - Sync internal input line-height and min/max-height from 24px to 28px - Adjust border-radius from 21px to 24px to match new height
When sending a message fails while the session is still busy (e.g. PROCESSING state), the state was transitioned to ERROR but never reset to IDLE. This caused the session to appear stuck in an error state: - Subsequent DialogTurnCompleted events were ignored - BACKEND_STREAM_COMPLETED and FINISHING_SETTLED transitions were skipped - The UI showed a persistent 'stoppable' indicator even though the session had already finished Also add ERROR_OCCURRED and RESET to the state transition logging whitelist for better debuggability. Generated with BitFun Co-Authored-By: BitFun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. fix(deep-review): make subagent ignore-timeout work correctly
timeout_secondsthrough backend events and frontend tool stateDialogTurnStartedwithsubagent_parent_infoso frontend can link subagent sessions to parent tools2. fix(web-ui): reset session state to idle after send message failure
RESETafterERROR_OCCURREDto prevent stuck sessionsERROR_OCCURREDandRESETto state transition logging whitelist3. style(chat-input): relax collapsed input capsule sizing
42px→48px, max-width300px→min(380px, 80%)24px→28px, border-radius21px→24px4. refactor(core): generalize frontend reviewer description beyond React
ReviewFrontendtoCORE_REVIEWER_AGENT_TYPES, update budget tracker test