Skip to content

fix(desktop): tighten companion pet bubble width measurement #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobleer merged 1 commit into from
May 8, 2026
+24 −6
Merged

fix(desktop): tighten companion pet bubble width measurement #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions src/web-ui/src/app/components/AgentCompanionDesktopPet/AgentCompanionDesktopPet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ const PET_SIZE = 96;
const WINDOW_MAX_WIDTH = 360;
const WINDOW_MAX_HEIGHT = 240;
const WINDOW_HORIZONTAL_GAP = 8;
const MAX_VISIBLE_BUBBLES = 3;
const MAX_VISIBLE_BUBBLES = 2;
const BUBBLE_GAP = 6;
const BUBBLE_MIN_WIDTH = 132;
const BUBBLE_MAX_WIDTH = 252;
const WINDOW_EDGE_BUFFER = 4;

export const AgentCompanionDesktopPet: React.FC = () => {
const { t } = useTranslation('flow-chat');
Expand Down Expand Up @@ -84,12 +87,27 @@ export const AgentCompanionDesktopPet: React.FC = () => {
const nextHeight = bubbleCount > 0
? Math.max(PET_SIZE, Math.min(WINDOW_MAX_HEIGHT, targetBubbleHeight))
: PET_SIZE;
const measuredDockWidth = dockRef.current
? Math.max(
dockRef.current.scrollWidth,
dockRef.current.getBoundingClientRect().width,
const measuredBubbleWidth = bubbleCount > 0
? Math.min(
BUBBLE_MAX_WIDTH,
Math.max(
BUBBLE_MIN_WIDTH,
bubblesRef.current?.scrollWidth ?? 0,
bubblesRef.current?.getBoundingClientRect().width ?? 0,
...Array.from(bubblesRef.current?.children ?? []).map(child => {
const element = child as HTMLElement;
return Math.max(element.scrollWidth, element.getBoundingClientRect().width);
}),
),
)
: PET_SIZE;
: 0;
const measuredDockWidth = bubbleCount > 0
? measuredBubbleWidth + WINDOW_HORIZONTAL_GAP + PET_SIZE + WINDOW_EDGE_BUFFER
: Math.max(
PET_SIZE,
dockRef.current?.scrollWidth ?? 0,
dockRef.current?.getBoundingClientRect().width ?? 0,
);
const nextWidth = Math.max(
PET_SIZE,
Math.min(WINDOW_MAX_WIDTH, Math.ceil(measuredDockWidth)),
Expand Down
Loading