fix: flashgrep lifecycle cleanup#615
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change tightens flashgrep lifecycle management so the workspace search daemon is owned and cleaned up through a unified core path instead of relying on desktop-only exit cleanup.
What changed
Arcto aWeakreference so the service can actually dropWhy
Users reported that
flashgrepcould remain alive after BitFun exited. The root issue was that lifecycle ownership was not strict RAII: the search service was globally strongly referenced, and daemon cleanup depended too much on explicit desktop shutdown plumbing.This refactor makes the ownership model tighter and gives the daemon both an explicit shutdown path and a drop-time fallback.
Impact
Validation
cargo check --workspacecargo test --workspace