refactor(skills): isolate builtin skills and centralize mode skill resolution#620
Merged
Conversation
- move bundled skills from the user skills root into `skills/.system` - add build-time builtin skill bundle hashing and manifest-based sync - rebuild `.system` on builtin skill bundle changes to avoid stale files - separate builtin skill registry slot from user-installed BitFun skills - skip `.system` during normal user skill root scanning - migrate legacy root-level builtin skills only when `.system` is first created - clean up historical builtin/superpowers legacy directories during first migration
- replace string-scattered default skill logic with catalog, policy, and resolver layers - move mode skill resolution into core SkillRegistry and expose richer mode skill state - add default/effective/state-reason fields to mode skill DTOs while keeping compatibility fields - update desktop skill API to consume centralized skill resolution logic - update ChatInput and agent/profile pages to use resolved mode skill state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the skill system to improve separation of concerns and make mode skill resolution more consistent across core, desktop, and frontend.
Changes
skills/.systemdirectoryImpact