Skip to content

refactor(skills): isolate builtin skills and centralize mode skill resolution#620

Merged
GCWing merged 2 commits into
GCWing:mainfrom
wsp1911:main
May 9, 2026
Merged

refactor(skills): isolate builtin skills and centralize mode skill resolution#620
GCWing merged 2 commits into
GCWing:mainfrom
wsp1911:main

Conversation

@wsp1911
Copy link
Copy Markdown
Collaborator

@wsp1911 wsp1911 commented May 9, 2026

Summary

This PR refactors the skill system to improve separation of concerns and make mode skill resolution more consistent across core, desktop, and frontend.

Changes

  • isolate builtin skills under the managed skills/.system directory
  • add manifest/hash-based builtin skill sync to prevent stale bundled files
  • separate builtin skill registration from user-installed skills
  • centralize mode skill resolution in core via catalog, policy, and resolver layers
  • extend mode skill DTOs with richer resolved state while keeping compatibility fields
  • update desktop skill APIs and related frontend pages to consume resolved mode skill state

Impact

  • reduces coupling between builtin and user-managed skills
  • makes skill resolution behavior easier to maintain and reason about
  • provides more explicit mode skill state for UI and adapter layers

- move bundled skills from the user skills root into `skills/.system`
- add build-time builtin skill bundle hashing and manifest-based sync
- rebuild `.system` on builtin skill bundle changes to avoid stale files
- separate builtin skill registry slot from user-installed BitFun skills
- skip `.system` during normal user skill root scanning
- migrate legacy root-level builtin skills only when `.system` is first created
- clean up historical builtin/superpowers legacy directories during first migration
@wsp1911 wsp1911 marked this pull request as ready for review May 9, 2026 05:17
@wsp1911 wsp1911 changed the title refactor(skills): isolate builtin skills and centralize mode skill resolution [WIP] refactor(skills): isolate builtin skills and centralize mode skill resolution May 9, 2026
- replace string-scattered default skill logic with catalog, policy, and resolver layers
- move mode skill resolution into core SkillRegistry and expose richer mode skill state
- add default/effective/state-reason fields to mode skill DTOs while keeping compatibility fields
- update desktop skill API to consume centralized skill resolution logic
- update ChatInput and agent/profile pages to use resolved mode skill state
@wsp1911 wsp1911 changed the title [WIP] refactor(skills): isolate builtin skills and centralize mode skill resolution refactor(skills): isolate builtin skills and centralize mode skill resolution May 9, 2026
@GCWing GCWing merged commit 7226e65 into GCWing:main May 9, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants