fix(web-ui): handle failed dialog completion in flow chat and notifications#636
Merged
bobleer merged 1 commit intoMay 10, 2026
Merged
Conversation
…ations - Route unsuccessful DialogTurnCompleted through failure handling and settle subagent tool items as error with finish_reason context - Pass success and finishReason into background completion notification copy - Add notify strings for failed dialog completion (en/zh-CN/zh-TW) - Extend unit tests for EventHandlerModule and useDialogCompletionNotify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DialogTurnCompletedwithsuccess: falseas a failed turn: invoke failure handling and settle subagent tool items as error with contextualfinish_reason.finishReason.notify.*strings for failed dialog completion (en, zh-CN, zh-TW).EventHandlerModuleanduseDialogCompletionNotify.Verification
pnpm run lint:webpnpm run type-check:web