fix(browser-control): accurate tab count, real browser detection, hide selector when CDP connected#640
Merged
bobleer merged 2 commits intoMay 11, 2026
Conversation
When the user clicks the disable-timeout button, the denominator now shows an infinity icon instead of the original timeout value, making it clear that the timeout has been removed. Generated with BitFun Co-Authored-By: BitFun
…e selector when CDP connected - Only count CDP targets of type 'page' as tabs (ignore service workers, browser targets etc.) - Detect actual connected browser from CDP /json/version instead of user config - Add browser_kind_from_cdp_version() to parse browser identity from CDP version string - Hide browser selection dropdown when CDP is already connected; only show when not connected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 3 browser control issues:
Added browser_kind_from_cdp_version() to parse browser identity from CDP version string.