Skip to content

feat(installer): add install detection and uninstaller launch support #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GCWing merged 1 commit into from
May 11, 2026
Merged

feat(installer): add install detection and uninstaller launch support #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions BitFun-Installer/scripts/build-installer.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,6 @@ function getCandidateAppExePaths(mode) {
profile,
"bitfun-desktop.exe"
),
path.join(
BITFUN_ROOT,
"target",
"x86_64-pc-windows-msvc",
profile,
"BitFun.exe"
),
path.join(
BITFUN_ROOT,
"src",
Expand All @@ -175,17 +168,7 @@ function getCandidateAppExePaths(mode) {
profile,
"bitfun-desktop.exe"
),
path.join(
BITFUN_ROOT,
"src",
"apps",
"desktop",
"target",
profile,
"BitFun.exe"
),
path.join(BITFUN_ROOT, "target", profile, "bitfun-desktop.exe"),
path.join(BITFUN_ROOT, "target", profile, "BitFun.exe")
path.join(BITFUN_ROOT, "target", profile, "bitfun-desktop.exe")
);
}

Expand Down Expand Up @@ -243,14 +226,14 @@ if (appExePath) {
files: [],
};

const destExe = path.join(PAYLOAD_DIR, "BitFun.exe");
const destExe = path.join(PAYLOAD_DIR, "bitfun-desktop.exe");
writeFileWithManifest(appExePath, destExe, manifest, PAYLOAD_DIR);
log(`Copied: ${appExePath} -> ${destExe}`);

const exeSize = fs.statSync(destExe).size;
if (STRICT_PAYLOAD_VALIDATION && exeSize < MIN_APP_EXE_BYTES) {
error(
`BitFun.exe in payload is unexpectedly small (${exeSize} bytes). Refusing to continue.`
`bitfun-desktop.exe in payload is unexpectedly small (${exeSize} bytes). Refusing to continue.`
);
}

Expand Down
Loading
Loading