Support ACP clients in remote workspaces and harden startup handling#679
Merged
Merged
Conversation
wgqqqqq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR adds ACP support for remote workspaces and tightens the ACP session lifecycle around restore and startup.
Why
Before this stack, ACP support was local-only and remote workspaces could not reliably start built-in ACP clients. Session restore and permission state around ACP sessions also had rough edges in FlowChat. Separately, first-time or not-yet-configured Codex / Claude Code installs could hang indefinitely in login or startup paths because the ACP client startup sequence had no hard timeout.
User impact
Users can now launch supported built-in ACP clients in remote workspaces, restore ACP session state more predictably, and get a clear startup failure instead of an indefinite hang when an ACP client is stuck during startup.
Root cause
The ACP stack was missing a remote-workspace path for built-in clients and had no bounded timeout around ACP initialize / session bootstrap. Some UI flows also assumed local ACP session behavior and did not preserve ACP-specific restore state consistently.
Validation
pnpm run type-check:webpnpm --dir src/web-ui exec vitest run src/app/components/NavPanel/sections/workspaces/workspaceAcpMenuClients.test.ts src/flow_chat/tool-cards/ReadFileDisplay.test.tsx src/flow_chat/services/flow-chat-manager/PersistenceModule.test.tscargo test -p bitfun-acp manager -- --nocapturecargo check -p bitfun-desktop