Move integration runtime helpers out of core#695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-services-integrations::remote_ssh::RemoteWorkspaceRegistrywhile keepingbitfun-coreas the product assembly wrapper for local assistant path guarding and SSH/file/terminal manager handles.bitfun-services-integrations::announcement::AnnouncementStateStore, preserving the existing corePathManagerconstructor and error mapping through a compatibility wrapper.Functional impact
This is intended to be behavior-preserving. The PR does not move SSH channel/SFTP/PTY execution, remote-connect runtime, MCP dynamic tools,
ToolUseContext, concrete tool implementations, miniapp/function-agent runtime, agent registry, or product feature assembly.Core still performs the local assistant workspace guard before remote path resolution. Remote workspace ambiguous-root handling, active connection hinting, legacy state snapshot shape, announcement load fallback, and announcement save semantics are covered by tests after the ownership move.
Validation
node scripts/check-core-boundaries.mjs$env:BITFUN_BOUNDARY_CHECK_SELF_TEST='1'; node scripts/check-core-boundaries.mjsrustfmt --edition 2021 --check <touched rust files>git diff --check -- <pr files>cargo test -p bitfun-services-integrations --features "remote-ssh announcement file-watch"cargo test -p bitfun-core remote_workspace -- --nocapturecargo check -p bitfun-services-integrations --features product-fullcargo test -p bitfun-services-integrations --features product-fullcargo tree -p bitfun-services-integrations --no-default-features --depth 1 --edges featurescargo check --workspacecargo test --workspaceNote: the workspace checks still report the existing
bitfun-cliunusedReadimport warning insrc/apps/cli/src/ui/theme.rs; this PR does not touch that file.