Refactor MCP runtime ownership into services integrations#699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-services-integrationsbehind themcpfeature.bitfun-coreas the compatibility facade and product runtime assembly point for coreConfigServicestore adaptation, OAuth data-dir injection,BitFunErrormapping, and global tool registry wiring.bitfun-core, while existing MCP wire shapes, auth/config behavior, dynamic manifest metadata, and remote Streamable HTTP behavior stay covered.Product / Behavior Boundary
This PR is intended as a structural ownership refactor plus documentation guardrail update only. It preserves the existing product runtime behavior through core facades and explicit adapter injection, and does not change MCP configuration semantics, OAuth storage location semantics, tool registry ownership, remote-connect behavior, CLI/Desktop/Remote/ACP presentation behavior, or feature defaults.
Validation
git diff --check gcwing/main...HEADnode scripts/check-core-boundaries.mjs$env:BITFUN_BOUNDARY_CHECK_SELF_TEST='1'; node scripts/check-core-boundaries.mjscargo test -p bitfun-services-integrations --features mcp --test mcp_contracts -- --nocapturecargo check -p bitfun-services-integrations --no-default-featurescargo check -p bitfun-corecargo test -p bitfun-core dynamic_tool_provider_prefers_mcp_registry_metadata -- --nocapturecargo test -p bitfun-core merge_dynamic_mcp_tools_appends_registered_mcp_tools_once -- --nocapturecargo test -p bitfun-core remote_mcp_streamable_http_accepts_202_and_delivers_response_via_sse -- --nocapturecargo check --workspacecargo test --workspacegit diff --check;git diff -- package.json scripts/dev.cjs scripts/desktop-tauri-build.mjs scripts/ensure-openssl-windows.mjs scripts/ci/setup-openssl-windows.ps1 BitFun-InstallerNotes: workspace check/test pass with an existing CLI unused-import warning for
src/apps/cli/src/ui/theme.rs:4.cargo test --workspacealso emitted a Windows incremental compilation finalize warning, but exited successfully and all tests passed.