bundle linux flashgrep in windows builds#728
Merged
Merged
Conversation
wgqqqqq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle the available Linux
flashgrepbinaries into Windows desktop builds so remote Linux workspace search can upload the correct daemon from a packaged Windows app.Why
The remote workspace search path already supports Linux-only remote
flashgrepsessions, but packaged Windows builds only injected the Windows binary into Tauri resources. That leftWindows -> Linux workspacesearch without a bundled Linux binary to upload at runtime.Impact
Packaged Windows desktop builds now include the existing Linux
flashgrepresources in addition to the native Windows binary. Other platforms keep the current behavior.Validation
node --check scripts/desktop-tauri-build.mjs