Skip to content

fix(miniapp): refine PR review inbox behavior#743

Merged
limityan merged 1 commit into
mainfrom
yanzhn/fix-pr-review-miniapp
May 15, 2026
Merged

fix(miniapp): refine PR review inbox behavior#743
limityan merged 1 commit into
mainfrom
yanzhn/fix-pr-review-miniapp

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

Summary

Refines the built-in PR Review MiniApp so the review workflow stays focused on actionable feedback and the PR detail layout is less jumpy and less tall.

Changes

  • Preserve the PR detail scroll position when switching changed files.
  • Mark each PR in the left queue as Draft or Ready with distinct chip styling.
  • Collapse the overview by default and show only a one-line description preview until expanded.
  • Cap the changed-file list height so it no longer stretches the PR detail page too far.
  • Change AI draft generation to prefer actionable JSON findings and inline review items; general summary comments are no longer created as selected publishable output by default unless the model explicitly returns a principle-level summaryComment.
  • Add focused built-in MiniApp asset tests covering the scroll preservation and compact/actionable review behavior.

Verification

  • node --check src/crates/core/src/miniapp/builtin/assets/pr-review/ui.js
  • cargo test -p bitfun-core bundled_pr_review -- --nocapture

Keep PR detail scroll position stable when switching changed files, mark draft and ready PRs in the queue, collapse long overview text by default, constrain the changed-file list height, and make generated review drafts focus on actionable findings instead of publishing selected summary comments by default.
@limityan limityan marked this pull request as ready for review May 15, 2026 14:01
@limityan limityan merged commit be287e1 into main May 15, 2026
4 checks passed
@GCWing GCWing deleted the yanzhn/fix-pr-review-miniapp branch May 28, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant