Improve startup and historical session readiness#754
Merged
Conversation
Add startup phase tracing across desktop and web startup, reduce pre-render initialization work, and dedupe concurrent config reads. Track historical session hydrate state explicitly so saved sessions show a loading or retry surface instead of briefly looking like a new empty session. Add focused tests for startup tracing, config read dedupe, historical session state transitions, retry UI, pending hydrate reuse, ACP restore skip, and Modern store sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves startup observability and historical session readiness without changing
chunkSizeWarningLimitand without submitting design or baseline documents.Changes
ConfigManager.getConfig()reads for the same path to avoid repeated IPC during startup bursts.metadata-only,hydrating,ready,failed) so opening a saved session shows a loading/retry state instead of briefly looking like a new empty session.Performance Results
Local release-like startup sampling, 3 runs each:
Historical-session UX improvement: saved sessions now enter a visible loading/retry lifecycle immediately, instead of falling through to the new-session empty state while turns are hydrating.
Risks / Follow-ups
Validation
git diff --cached --checkrustfmt --edition 2021 --check --config skip_children=true src\apps\desktop\src\lib.rs src\apps\desktop\src\theme.rspnpm run lint:webpnpm run type-check:webpnpm --dir src/web-ui run test:run(124 files / 650 tests)cargo check -p bitfun-desktopcargo test -p bitfun-desktop(27 tests)pnpm run desktop:build:release-fastpassed during local milestone verification; existing Vite chunk warnings are still present.