refactor(tools): add catalog runtime facades#811
Merged
limityan merged 1 commit intoMay 21, 2026
Merged
Conversation
Move provider-backed tool catalog and GetToolSpec facade entrypoints into bitfun-agent-tools while keeping product registry snapshots, ToolUseContext, unlock state, and concrete tool behavior owned by core. Update boundary guards and decomposition docs to reflect the remaining H1 owner work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolCatalogRuntimeand expandGetToolSpecRuntimeinbitfun-agent-toolsso generic visible-tools, prompt-visible manifest, readonly catalog, static tool surface, catalog description, and execution-result assembly have a single owner facade.ToolUseContext, collapsed unlock state,GetToolSpecToolTool impl, snapshot wrapping, and concrete tools inbitfun-core.Behavior / Boundary Notes
Validation
node scripts/check-core-boundaries.mjscargo test -p bitfun-agent-tools --test tool_contractscargo test -p bitfun-core get_tool_spec --libcargo test -p bitfun-core manifest_ --libcargo test -p bitfun-core product_catalog_facade --libcargo check -p bitfun-agent-toolscargo check -p bitfun-corecargo check -p bitfun-core --features product-fullcargo check --workspacecargo test --workspacerustfmt --edition 2021 --check src/crates/agent-tools/src/framework.rs src/crates/agent-tools/src/lib.rs src/crates/agent-tools/tests/tool_contracts.rs src/crates/core/src/agentic/tools/catalog_provider.rs src/crates/core/src/agentic/tools/registry.rsgit diff --check