Skip to content

refactor(tools): add catalog runtime facades#811

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-tool-runtime-h1-get-tool-spec-runtime
May 21, 2026
Merged

refactor(tools): add catalog runtime facades#811
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-tool-runtime-h1-get-tool-spec-runtime

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

Summary

  • Add provider-backed ToolCatalogRuntime and expand GetToolSpecRuntime in bitfun-agent-tools so generic visible-tools, prompt-visible manifest, readonly catalog, static tool surface, catalog description, and execution-result assembly have a single owner facade.
  • Keep product registry snapshots, agent policy lookup, ToolUseContext, collapsed unlock state, GetToolSpecTool Tool impl, snapshot wrapping, and concrete tools in bitfun-core.
  • Update boundary guards and decomposition docs to reflect the completed H1 facade slices and the remaining high-risk owner work.

Behavior / Boundary Notes

  • No feature behavior is intentionally changed.
  • Core still owns product-specific state and execution boundaries; the new facades delegate to existing resolver/filter helpers.
  • Added regression coverage for manifest ordering, allowed-list insertion, readonly enabled filtering, GetToolSpec static surface, and provider-backed execution paths.

Validation

  • node scripts/check-core-boundaries.mjs
  • cargo test -p bitfun-agent-tools --test tool_contracts
  • cargo test -p bitfun-core get_tool_spec --lib
  • cargo test -p bitfun-core manifest_ --lib
  • cargo test -p bitfun-core product_catalog_facade --lib
  • cargo check -p bitfun-agent-tools
  • cargo check -p bitfun-core
  • cargo check -p bitfun-core --features product-full
  • cargo check --workspace
  • cargo test --workspace
  • rustfmt --edition 2021 --check src/crates/agent-tools/src/framework.rs src/crates/agent-tools/src/lib.rs src/crates/agent-tools/tests/tool_contracts.rs src/crates/core/src/agentic/tools/catalog_provider.rs src/crates/core/src/agentic/tools/registry.rs
  • git diff --check

Move provider-backed tool catalog and GetToolSpec facade entrypoints into bitfun-agent-tools while keeping product registry snapshots, ToolUseContext, unlock state, and concrete tool behavior owned by core.

Update boundary guards and decomposition docs to reflect the remaining H1 owner work.
@limityan limityan merged commit 418e242 into GCWing:main May 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant