refactor(runtime): centralize core runtime owners#824
Merged
limityan merged 1 commit intoMay 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the current HR2 + HR3 runtime-owner closure work into a single commit after rebasing onto the latest
GCWing/BitFun:main.What changed:
CoreProductDomainRuntimeas the core-owned binding point for product-domain runtime adapters.CoreServiceAgentRuntimeas the core-owned binding point for service/agent runtime adapters.What this intentionally does not change:
Risk Review
The main risk would be accidentally treating core-owned runtime paths as migrated owner-crate behavior. This PR keeps those paths in core and only centralizes the adapter entry points. The added boundary rules and focused tests guard the current ownership line so future runtime migration needs a separate port/provider design and equivalence tests.
Validation
rustfmt --edition 2021 --check --config skip_children=true ...node scripts/check-core-boundaries.mjsgit diff --check gcwing/main..HEADcargo test -p bitfun-core core_product_domain_runtime_owner -- --nocapturecargo test -p bitfun-core core_service_agent_runtime_owner -- --nocapturecargo test -p bitfun-core remote_ -- --nocapturecargo test -p bitfun-product-domains --features product-fullcargo test -p bitfun-services-integrations --features product-fullcargo check -p bitfun-core --features product-full