refactor(core): narrow no-default dependency profile#832
Merged
Conversation
c0b01c8 to
3391099
Compare
Move product/runtime-only direct dependencies behind existing feature gates while keeping product-full as the default complete runtime assembly. Document that service-integrations is still product-full-bound, add no-default dependency checks, enforce explicit feature owners for optional runtime dependencies, guard product entry crates so their bitfun-core dependency keeps explicit product-full assembly, scan product entry manifests for new direct core dependency coverage, and keep owner crate default/product-full feature graphs explicit.
3391099 to
f2ceb72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-coredefault behavior as the completeproduct-fullruntime assembly while moving product/runtime-only direct dependencies behind existing feature gates.scripts/check-core-boundaries.mjsinto the H5 feature graph guard: no-default dependency profile, optional dependency feature owners, product-entry explicit core assembly, product-entry scan coverage, current core default guard, and owner crate default-light / explicitproduct-fullfeature-group checks.Functional Boundary
default-features = falsewithfeatures = [product-full].bitfun-core default = [product-full]stays locked until a separate product matrix review.tool-packs,services-integrations, andproduct-domainskeepdefault = []; theirproduct-fullfeatures explicitly aggregate current owner feature groups.Validation
bitfun-coreno-default, product-full, and ssh-remote combinations.git diff --checkand build/release script diff guard.