Skip to content

refactor(core): narrow no-default dependency profile#832

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-core-feature-deps
May 22, 2026
Merged

refactor(core): narrow no-default dependency profile#832
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-core-feature-deps

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

@limityan limityan commented May 21, 2026

Summary

  • Keep bitfun-core default behavior as the complete product-full runtime assembly while moving product/runtime-only direct dependencies behind existing feature gates.
  • Extend scripts/check-core-boundaries.mjs into the H5 feature graph guard: no-default dependency profile, optional dependency feature owners, product-entry explicit core assembly, product-entry scan coverage, current core default guard, and owner crate default-light / explicit product-full feature-group checks.
  • Update decomposition docs plus affected crate AGENTS guides without changing runtime logic, product behavior, Cargo manifests, release scripts, or build scripts.

Functional Boundary

  • Product entries still use default-features = false with features = [product-full].
  • bitfun-core default = [product-full] stays locked until a separate product matrix review.
  • tool-packs, services-integrations, and product-domains keep default = []; their product-full features explicitly aggregate current owner feature groups.
  • This is a feature/dependency boundary guard only, not runtime owner deep migration, per-product feature matrix, or build-benefit claim.

Validation

  • Boundary checks: regular + self-test.
  • Core checks: bitfun-core no-default, product-full, and ssh-remote combinations.
  • Product checks: ACP, CLI, Desktop, Server.
  • Owner checks/tests: tool-packs, services-integrations, and product-domains no-default/product-full profiles.
  • Focused core tests: workspace session identity and core service-agent runtime owner.
  • Diff checks: git diff --check and build/release script diff guard.

@limityan limityan force-pushed the yanzhn/refactor-core-feature-deps branch 3 times, most recently from c0b01c8 to 3391099 Compare May 21, 2026 13:12
Move product/runtime-only direct dependencies behind existing feature gates while keeping product-full as the default complete runtime assembly.

Document that service-integrations is still product-full-bound, add no-default dependency checks, enforce explicit feature owners for optional runtime dependencies, guard product entry crates so their bitfun-core dependency keeps explicit product-full assembly, scan product entry manifests for new direct core dependency coverage, and keep owner crate default/product-full feature graphs explicit.
@limityan limityan force-pushed the yanzhn/refactor-core-feature-deps branch from 3391099 to f2ceb72 Compare May 21, 2026 13:20
@limityan limityan merged commit 6bcbbcf into GCWing:main May 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant