Skip to content

refactor(runtime): centralize service agent adapters#877

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/hr-c-service-agent-runtime
May 26, 2026
Merged

refactor(runtime): centralize service agent adapters#877
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/hr-c-service-agent-runtime

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

@limityan limityan commented May 25, 2026

Summary

  • Centralize the remaining core-owned remote service/agent runtime adapters in CoreServiceAgentRuntime while keeping product behavior and wire contracts unchanged.
  • Move concrete remote dialog/cancel/file/tracker host bindings, remote model catalog and session-model selection config adapters, and remote chat history persistence/message conversion adapters out of remote_server.rs.
  • Keep remote_server.rs as command dispatch/routing only; it now delegates persisted remote chat loading through the owner adapter.
  • Add boundary-script guards and owner tests for remote chat history shape, in-progress assistant history skipping, thumbnail compression ownership, and enhanced user-input display cleanup.
  • Update architecture and module docs to clarify that this PR is a core owner-closure step, not a migration of broad persistence/workspace ownership, remote-SSH runtime, scheduler/session restore, feature matrix, or product behavior.

Behavior Boundary

  • No remote command, response, DTO, feature flag, product release shape, scheduler policy, workspace-root selection, or remote-SSH behavior is changed.
  • Persisted turn to mobile ChatMessage conversion preserves existing ordering, tool/thinking/text filtering, original-text display preference, image thumbnail policy, and in-progress assistant-message suppression.
  • Concrete persistence reads remain core-owned; this PR only moves the remote chat history adapter from remote_server.rs into the existing core owner module.

Verification

  • node scripts/check-core-boundaries.mjs
  • node scripts/check-core-boundaries.mjs --self-test
  • cargo test -p bitfun-core core_service_agent_runtime_owner -- --nocapture
  • cargo check -p bitfun-core --features product-full
  • cargo test -p bitfun-core remote_execution_prefers_unified_image_contexts_over_legacy_images -- --nocapture
  • cargo test -p bitfun-services-integrations --features remote-connect
  • git diff --check
  • git merge-base --is-ancestor gcwing/main HEAD
  • cargo check --workspace
  • cargo test --workspace

@limityan limityan force-pushed the yanzhn/hr-c-service-agent-runtime branch from a391e9e to 897745d Compare May 26, 2026 01:47
@limityan limityan force-pushed the yanzhn/hr-c-service-agent-runtime branch from 897745d to cda3ef7 Compare May 26, 2026 02:28
@limityan limityan merged commit ae90887 into GCWing:main May 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant