refactor(runtime): move tool context owner boundary#884
Merged
Conversation
8ab5f6a to
bcc7f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolUseContexttype, portable facts projection, runtime/service bindings, and unifiedTool::callruntime hook facade intotool_context_runtime.rs.framework.rsas the compatibility re-export +Tooltrait boundary only; move the Deep Review post-call hook regression into the runtime owner tests.ToolUseContextfrom the owner module instead of relying on the framework re-export.tool_context_runtime.rs.Behavior boundary
ToolUseContextremains core-owned; workspace services, cancellation token, Deep Review hooks, dynamic MCP execution, Read/Edit/Write IO, and tool-result filesystem persistence are not moved out of core.Improve goal mode guidance (#883); that change touches goal-mode/coordinator code and does not alter this HR-A tool-runtime owner plan.Verification
node scripts\\check-core-boundaries.mjsnode scripts\\check-core-boundaries.mjs --self-testcargo test -p bitfun-core tool_context -- --nocapturecargo test -p bitfun-core tool_call_runtime_hook -- --nocapturecargo test -p bitfun-core call_records_deep_review_read_file_measurement_without_touching_result -- --nocapturecargo test -p bitfun-core product_tool -- --nocapturecargo test -p bitfun-core manifest -- --nocapturecargo test -p bitfun-agent-toolscargo check -p bitfun-core --features product-fullcargo check --workspacecargo test --workspacegit diff --check