refactor: move local filesystem owner to services-core#891
Merged
Conversation
Move platform-neutral filesystem operations, listing, tree/search, and service facade into bitfun-services-core while keeping core as the remote-overlay and BitFunError compatibility layer. Add boundary checks and documentation updates for the filesystem owner split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-services-core::filesystem.bitfun-corefilesystem paths as compatibility facades, withcore::service::filesystem::FileSystemServicelimited to remote-workspace overlay, legacyBitFunErrormapping, and old API compatibility.Behavior and compatibility
Risk review
bitfun-services-core::filesystem::FileSystemService.PathManagerbinding, or remote SSH runtime ownership is moved in this PR.Verification
cargo test -p bitfun-services-core filesystem -- --nocapturenode scripts\\check-core-boundaries.mjscargo check -p bitfun-core --features product-fullcargo check -p bitfun-desktop(existing dead_code warning inclipboard_file_api.rs)cargo check -p bitfun-servergit diff --check