fix(agentic): reject tool-invocation syntax in Write content generation#902
Merged
bobleer merged 1 commit intoMay 26, 2026
Merged
Conversation
Strip DSML and nested tool-call artifacts from Write file-body generation, retry once on streamed content, and validate inline Write payloads before write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_content_sanitizerto detect and strip DSML / nested tool-call artifacts from Write file-body generation.Writetoolcontentbefore persisting to disk.Context
Models sometimes emit DSML blocks (
<||DSML||tool_calls>,<invoke>, etc.) or nested tool-call XML inside Write content streams. This PR prevents that syntax from being written to disk and gives the agent a clear retry/failure path.Test plan
cargo test -p bitfun-core write_content_sanitizercargo test -p bitfun-core sanitization_strips_dsmlcargo check -p bitfun-core