refactor(remote-connect): move runtime presentation policies#938
Merged
limityan merged 1 commit intoMay 29, 2026
Merged
Conversation
Move remote chat history presentation assembly and remote model selection policy into services-integrations. Keep core as the persistence/config adapter so remote execution, scheduler, terminal, SSH, and workspace behavior remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-services-integrations, including assistant message assembly, thinking/text/tool item ordering, tool preview generation, in-progress assistant history skipping, and tool input exposure policy.AIConfigand injecting the model-reference resolver.bitfun-coreas the concrete runtime adapter for persistence reads, image compression, enhanced remote input cleanup, session restore, terminal pre-warm, scheduler submit, workspace-root lookup, and remote SSH/runtime execution.Behavior and Boundary Notes
This PR is intended as structural runtime-owner migration only. It does not change remote-connect wire shapes, remote execution flow, scheduler behavior, terminal lifecycle, remote SSH behavior, workspace persistence, model config loading, or product surface commands.
Core now projects persisted
DialogTurnDatainto owner DTOs and delegates presentation assembly toservices-integrations. The owner crate receives focused contract coverage for message shape/order, in-progress assistant skip behavior, and model selection alias/config-reference policy.Validation
cargo test -p bitfun-services-integrations --features remote-connect --test remote_connect_contracts -- --nocapturecargo test -p bitfun-core core_service_agent_runtime_owner -- --nocapturenode scripts\check-core-boundaries.mjscargo check -p bitfun-core --features product-fullcargo check --workspacegit diff --checkcargo check --workspacestill reports the existingparse_clipboard_path_segmentsdead-code warning insrc/apps/desktop/src/api/clipboard_file_api.rs, unrelated to this PR.