This repository was archived by the owner on Oct 21, 2022. It is now read-only.
shuffle.js: remove newlines and carriage returns from gdPath before using it#20
Merged
GDColon merged 2 commits intoGDColon:masterfrom Jun 15, 2022
layercak3:fix-gdpath-read
Merged
shuffle.js: remove newlines and carriage returns from gdPath before using it#20GDColon merged 2 commits intoGDColon:masterfrom layercak3:fix-gdpath-read
GDColon merged 2 commits intoGDColon:masterfrom
layercak3:fix-gdpath-read
Conversation
Owner
|
Sounds good, just accepted a PR though so fix the conflict if possible |
|
Hello! For some reason my GD randomizer is not opening, not because it crashed or couldn't find the game folder, do you have to use a specific program? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of users that edit
directory.txtmay get the couldn't find your GD directory error because there's a newline (or maybe a carriage return) in it which a lot of editors add at the end of the file (the popular Windows Notepad is an exception when creating new files). There's a whole rabbit hole you can go down on about line endings but essentially this PR removes them because otherwise they're read as part of the pathname which will cause the game directory to not be found.